#2559. Add augmenting declarations tests #2565
Conversation
There was a problem hiding this comment.
Looks good!
LanguageFeatures/Augmentation-libraries/merge_order_A01_t01.dart wouldn't be testable for a while because augmented isn't likely to be implemented during the next couple of months.
But the merging order could be tested without augmented by having the same graph (main plus lib1, lib2, lib3) and letting main introduce class A, lib1 augment class A and introduce class B, lib2 augment class B and introduce class C, and finally lib3 augment class C.
This could be done without using augmented anywhere, and it would test the ordering.
|
|
||
| // SharedOptions=--enable-experiment=macros | ||
|
|
||
| augment class C {} |
There was a problem hiding this comment.
If the language team (1) accepts the proposal that I hinted at in dart-lang/language#3647, or (2) tells me that we already have such a rule then this would be an error simply because it isn't in an augmentation library.
So we ought to have a test where it does occur in an augmentation library, and still there is no original declaration to augment.
There was a problem hiding this comment.
(This might be covered by tests further down, I haven't looked at them all).
LanguageFeatures/Augmentation-libraries/augmenting_declarations_A01_t03.dart
Outdated
Show resolved
Hide resolved
|
|
||
| import augment 'augmenting_declarations_A02_t01_lib.dart'; | ||
|
|
||
| /**/augment class C {} |
There was a problem hiding this comment.
If they accept #3647 then this would be a different error, in which case the description would need to be adjusted.
sgrekhov
changed the title
sgrekhov
added
the
status-blocked
|
Merge order tests updated and moved to #2566. This one is blocked by dart-lang/language#3647 for now |
I'm not sure we have a clear policy, but perhaps such PRs usually have a 'Draft' status? |
No description provided.