Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default cardinality to high for metrics #7732

Conversation

nelson-parente
Copy link

Description

This PR reverts the changes introduced in #7522 and restores the default cardinality until version 1.15. The intention is to revert to a lower cardinality as the default setting in the upcoming Dapr version. This is a temporary measure while we work on addressing other issues related to metrics cardinality.

Issue reference

Motivation described here: #7719

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
@nelson-parente nelson-parente requested review from a team as code owners May 15, 2024 09:09
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to revert this change, since this just controls the default value. You can always set increasedCardinality: true in your config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants