Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix perfs #7730

Closed
wants to merge 2 commits into from
Closed

chore: fix perfs #7730

wants to merge 2 commits into from
+6 −171

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented May 14, 2024 •
edited

Description

  • Uses k6-operator fork that is compatible with go1.22
    • updated controller-gen dep to 0.14.0
    • Incompatible CRDs removed
  • Removes azureblob storage steps

Will need to migrate to Testrun CRDs as k6 CRDs are deprecated (separate issue to be opened on/before merge)

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@mikeee mikeee requested review from a team as code owners May 14, 2024 19:42
@mikeee
Copy link
Member Author

mikeee commented May 14, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 14, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 70f49e4

✅ Build succeeded

  • Image tag: daprprfb2810a8194
  • Test image tag: daprprfb2810a8194

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfb2810a8194
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@yaron2
Copy link
Member

yaron2 commented May 14, 2024

That was a valiant effort. We are blocked on this: kubernetes-sigs/kubebuilder#3792 (comment)

@mikeee
Copy link
Member Author

mikeee commented May 14, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 14, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2590452

✅ Build succeeded

  • Image tag: daprprf41195033e8
  • Test image tag: daprprf41195033e8

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf41195033e8
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 14, 2024

@yaron2 I've got the perf tests running using a k6-operator fork, but I'm concerned about the high failure rate of the tests anyway. Is this flakiness or kubebuilder-blocking?

@mikeee
Copy link
Member Author

mikeee commented May 15, 2024

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 15, 2024 •
edited

Dapr E2E test

🔗 Link to Action run

Commit ref: 2590452

✅ Build succeeded for linux/amd64

  • Image tag: dapre2e2040df0848l
  • Test image tag: dapre2e2040df0848l

✅ Infrastructure deployed

Cluster Resource group name Azure region
Linux Dapr-E2E-dapre2e2040df0848l westus3
Windows Dapr-E2E-dapre2e2040df0848w westus3
Linux/arm64 Dapr-E2E-dapre2e2040df0848la eastus

✅ Build succeeded for windows/amd64

  • Image tag: dapre2e2040df0848w
  • Test image tag: dapre2e2040df0848w

❌ Tests failed on windows/amd64

Please check the logs for details on the error.

✅ Tests succeeded on linux/amd64

  • Image tag: dapre2e2040df0848l
  • Test image tag: dapre2e2040df0848l

@mikeee
Copy link
Member Author

mikeee commented May 15, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 15, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2590452

✅ Build succeeded

  • Image tag: daprprfb6b5058a4e
  • Test image tag: daprprfb6b5058a4e

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfb6b5058a4e
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 15, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 15, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2590452

✅ Build succeeded

  • Image tag: daprprfce1f110d67
  • Test image tag: daprprfce1f110d67

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfce1f110d67
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 15, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 15, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2590452

✅ Build succeeded

  • Image tag: daprprf883655a805
  • Test image tag: daprprf883655a805

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf883655a805
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 16, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 16, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2590452

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf6f758659bf
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprf6f758659bf
  • Test image tag: daprprf6f758659bf

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: f5dbb86

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf2fd8949327
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprf2fd8949327
  • Test image tag: daprprf2fd8949327

❌ Perf tests failed

Please check the logs for details on the error.

@mikeee mikeee changed the title chore: bump k6 operator to v0.0.14 chore: fix perfs May 30, 2024
@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2bdebd8

✅ Build succeeded

  • Image tag: daprprfd4251bb15a
  • Test image tag: daprprfd4251bb15a

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2bdebd8

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfe2c7c9c3db
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprfe2c7c9c3db
  • Test image tag: daprprfe2c7c9c3db

❌ Perf tests failed

Please check the logs for details on the error.

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 2585c00

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf5e0907a31a
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprf5e0907a31a
  • Test image tag: daprprf5e0907a31a

❌ Perf tests failed

Please check the logs for details on the error.

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 558545f

✅ Build succeeded

  • Image tag: daprprfe63cd89bea
  • Test image tag: daprprfe63cd89bea

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfe63cd89bea
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
chore: bump controller-gen to 0.14.0 and use k6-operator fork
16d24f0 
The fork is needed to bump controller-gen to 0.14.0.

Signed-off-by: mikeee <hey@mike.ee>
@mikeee
chore: remove azureblob outputs
bc47af1 
Signed-off-by: mikeee <hey@mike.ee>
@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Build succeeded

  • Image tag: daprprf5552bafb9f
  • Test image tag: daprprf5552bafb9f

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf5552bafb9f
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@JoshVanL JoshVanL mentioned this pull request May 30, 2024
Merged
@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Build succeeded

  • Image tag: daprprf11d029d6f9
  • Test image tag: daprprf11d029d6f9

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf11d029d6f9
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfdd13515cb3
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprfdd13515cb3
  • Test image tag: daprprfdd13515cb3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Build succeeded

  • Image tag: daprprf0dc20f7abe
  • Test image tag: daprprf0dc20f7abe

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf0dc20f7abe
  • Azure region: westus3

⚠️ Perf tests cancelled

The Action has been canceled

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Build succeeded

  • Image tag: daprprffc9aca1c80
  • Test image tag: daprprffc9aca1c80

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprffc9aca1c80
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@mikeee
Copy link
Member Author

mikeee commented May 30, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 30, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf89d7deb11f
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprf89d7deb11f
  • Test image tag: daprprf89d7deb11f

❌ Perf tests failed

Please check the logs for details on the error.

@daixiang0
Copy link
Member

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 31, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: bc47af1

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf31d061f350
  • Azure region: westus3

✅ Build succeeded

  • Image tag: daprprf31d061f350
  • Test image tag: daprprf31d061f350

❌ Perf tests failed

Please check the logs for details on the error.

@mikeee
Copy link
Member Author

mikeee commented May 31, 2024

/ok-to-perf

Looks like we're almost back to normal aside from the usual suspect - actor_reminder test asserted as 500qps and achieving around 50.

@mikeee mikeee closed this May 31, 2024
@mikeee
Copy link
Member Author

mikeee commented May 31, 2024

Closed in favour of #7775

@mikeee mikeee deleted the fix-perf branch May 31, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikeee @dapr-bot @yaron2 @daixiang0