-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(observability)(WIP): allow custom latency distribution buckets #7646
base: master
Are you sure you want to change the base?
Conversation
WIP Signed-off-by: Joey Freeland <joey@free.land>
262a062
to
a64a391
Compare
@jfreeland are you still working on this? |
my wedding, honeymoon, and day job have gotten in the way. i won't have time to revisit and test for the next couple weeks, unfortunately. if someone else has time and wants to make it happen elsewhere that'd be awesome. if not i'll revisit as soon as i can. |
Signed-off-by: Joey Freeland <30938344+jfreeland@users.noreply.github.com>
Signed-off-by: Joey Freeland <joey@free.land>
I think there's still work to do here but I think this is 'closer'. I didn't get a chance to dig around the I seem to recall a couple months ago that I regenerated the generated files myself but I didn't do that tonight. I don't recall seeing that I needed to in It might be cool if there was some simple app that could be used for local testing with https://tilt.dev like https://github.com/hashicorp-demoapp/hashicups-setups. I also spotted a little typo https://github.com/dapr/dapr/blob/master/pkg/diagnostics/grpc_monitoring.go#L57 |
I found @ItalyPaleAle 's reference to |
Description
Work In Progress.
This is intended to address #7641 and add support for users to provide an alternative list of distributions thresholds.
No tests. Not entirely sure this is the best approach. Not validated at all yet.
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: