-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Integration: Hot Reload spec.ignoreErrors
#7514
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7514 +/- ##
==========================================
- Coverage 61.39% 61.35% -0.04%
==========================================
Files 265 265
Lines 22609 22609
==========================================
- Hits 13880 13872 -8
- Misses 7579 7586 +7
- Partials 1150 1151 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are some errors in CI for placement vnodes
and component already exists
, maybe those are flaky?
637d323
to
826caa7
Compare
Adds integration tests that assert that the `spec.ignoreErrors` field works as expected when hot reloading a component, namely that daprd exits error when `spec.ignoreErrors=false` and continues running when `spec.ignoreErrors=true`. No implementation changes. Signed-off-by: joshvanl <me@joshvanl.dev>
0073a46
to
2cadd07
Compare
Adds integration tests that assert that the
spec.ignoreErrors
field is respected when hot reloading a component. Namely that daprd exits error whenspec.ignoreErrors=false
, and continues running whenspec.ignoreErrors=true
.No implementation changes.