Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor placement config and client out of internal #7446

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

artursouza
Copy link
Member

Description

Refactor placement config and client out of internal package to allow control plane service to also connect to placement service.

No behavior change.

Issue reference

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza requested review from a team as code owners January 24, 2024 21:04
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.40%. Comparing base (cc9d51e) to head (b3da7b3).
Report is 73 commits behind head on master.

Files Patch % Lines
pkg/actors/actors.go 50.00% 2 Missing ⚠️
pkg/actors/placement/placement.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7446      +/-   ##
==========================================
- Coverage   62.41%   62.40%   -0.01%     
==========================================
  Files         240      238       -2     
  Lines       22062    22040      -22     
==========================================
- Hits        13769    13755      -14     
+ Misses       7153     7141      -12     
- Partials     1140     1144       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -11,7 +11,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new package for the interfaces, don't move them inside placement which is a concrete implementation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Will move.

@@ -11,7 +11,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be in config. Maybe more in a package like interfaces, together with the placement interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Will move.

@yaron2 yaron2 added this to the v1.14 milestone Jan 24, 2024
@artursouza
Copy link
Member Author

Putting this on-hold for now. I might not need it.

@artursouza artursouza marked this pull request as draft January 25, 2024 00:33
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale Issues and PRs without response and removed stale Issues and PRs without response labels Mar 25, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issues and PRs without response label May 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.40%. Comparing base (cc9d51e) to head (b3da7b3).
Report is 158 commits behind head on master.

Files Patch % Lines
pkg/actors/actors.go 50.00% 2 Missing ⚠️
pkg/actors/placement/placement.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7446      +/-   ##
==========================================
- Coverage   62.41%   62.40%   -0.01%     
==========================================
  Files         240      238       -2     
  Lines       22062    22040      -22     
==========================================
- Hits        13769    13755      -14     
+ Misses       7153     7141      -12     
- Partials     1140     1144       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dapr-bot dapr-bot removed the stale Issues and PRs without response label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants