-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify dnsPolicy in sidecar injector helm chart #7407
base: master
Are you sure you want to change the base?
Conversation
Thanks for this contribution. Can you please add this option to the table here? https://github.com/dapr/dapr/tree/master/charts/dapr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7407 +/- ##
==========================================
+ Coverage 62.26% 62.31% +0.04%
==========================================
Files 245 240 -5
Lines 22380 22058 -322
==========================================
- Hits 13935 13745 -190
+ Misses 7289 7172 -117
+ Partials 1156 1141 -15 ☔ View full report in Codecov by Sentry. |
Sure. I've added an explanation of the new configuration option in the readme. Thanks |
@whytem please fix DCO. |
7746f5a
to
93c14f4
Compare
… is generally required when utilizing hostNetwork=true which is generally not cluster default Signed-off-by: Michael Whyte <m.whyte@gmail.com>
@daixiang0 Fixed! Thank you |
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
When enabling hostNetwork: true in the sidecar injector chart to resolve networking issues associated with using CNI on EKS, which results in the Kubernetes Control Plane being unable to access the sidecar injector webhook, it is often also necessary to set the pod's dnsPolicy to 'ClusterFirstWithHostNet' to prevent DNS issues.
The sidecar injector Helm Chart currently offers no ability to specify the dnsPolicy and hence it always reverts to the cluster default.
This straightforward PR adds the option to provide this value to the sidecar injector chart. If no value is explicitly specified, it continues using the cluster default per the existing behavior.
Issue reference
#4270
Checklist