Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port): add zed #212

Merged
merged 2 commits into from
May 19, 2024
Merged

feat(port): add zed #212

merged 2 commits into from
May 19, 2024

Conversation

dustessavdh
Copy link
Contributor

@dustessavdh dustessavdh commented May 18, 2024

Description

This PR: Adds support for the editor Zed.

The installation steps are written as if the package is already published.
To actually publish the package we would have to follow the steps listed in the extensions repo of Zed.
Since I don't want to make a PR without asking, I haven't done this yet.

For local installation, you can follow the following steps:

  1. Open the Command Palette with Ctrl + Shift + P or + Shift + P
  2. Open the Extensions view with the zed: extensions command
  3. Click on the Install Dev Extension button
  4. Select the packages/zed folder
  5. Open the Command Palette again
  6. Open the Theme selector with the theme selector: toggle command
  7. Search for Aura and choose an Aura variant.

Assets

Logo:
image

Screenshot:
image

Checklist

  • PR description included
  • I've read the documents
  • I've created or commented in an issue related to this port asking to work on it
  • I know I shouldn't change any files in the packages folder manually
  • I've added this port at the end of the related category list in the main README
  • I've attached an image to the icon of the app that this port is related to
  • I've attached a screenshot with a good zoom in fullscreen showing this port in action

feat(port): update readme
@daltonmenezes
Copy link
Owner

Hi @dustessavdh thanks, you can publish it for sure!

Also, please update the icon and banner to:

icon
banner

@dustessavdh dustessavdh mentioned this pull request May 19, 2024
1 task
@dustessavdh
Copy link
Contributor Author

dustessavdh commented May 19, 2024

Hi @daltonmenezes, I've updated the corresponding files!
I've also been trying to add it to the extensions repo, but I haven't fully figured out how to include this repo since they use git submodules.
I can add this repo as a submodule and use spare-checkout to only include this package, but it will still be under packages/zed, and I think the files must be in the root of the submodule.

I've added a question under zed-industries/extensions#36 to ask more about this
I've also figured out how to add this repo to the extensions repo!
Once this PR will be merged, I will be able to create a PR to add it to Zed

@daltonmenezes daltonmenezes self-requested a review May 19, 2024 15:03
@daltonmenezes daltonmenezes merged commit 3f7557a into daltonmenezes:main May 19, 2024
1 check passed
@daltonmenezes
Copy link
Owner

Thank you so much @dustessavdh 💜

@dustessavdh dustessavdh deleted the feat/zed branch May 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants