Inject telemetry script if telemetry enabled hosted on dagster.io #21814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petehunt
reviewed
May 14, 2024
| @@ -30,5 +30,10 @@ export const extractInitializationData = (): { | |||
| } | |||
| } | |||
| } | |||
| if (value.telemetryEnabled) { | |||
| const script = document.createElement('script'); | |||
There was a problem hiding this comment.
should we set defer and async?
petehunt
reviewed
May 14, 2024
| @@ -30,5 +30,10 @@ export const extractInitializationData = (): { | |||
| } | |||
| } | |||
| } | |||
| if (value.telemetryEnabled) { | |||
There was a problem hiding this comment.
testing this with telemetry on and off is important
There was a problem hiding this comment.
yeah this path has been tested for the existing telemetry stuff but I can double check
bengotow
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The script doesn't exist yet so this just 404s atm but we will be adding it soon.
How I Tested These Changes
Built the app, loaded it, confirmed everything works and that we load the script: