Replace deprecated utcfromtimestamp method #21799
Merged
+32
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2024 14:15
## Summary & Motivation Fixes issue mentioned by @psarka Refactors method to explicitly specify timezone when converting from unix timestamp to ISO8601. Discards the timezone for backwards compatibility as datetime. ## How I Tested These Changes There is probably a good learning opportunity for me here. I used this snippet. Please educate me about how you want to do this properly. # convert unix timestamp at UTC at second precision to iso8601 timestamp at implicit utc of type timestamp.timestamp from datetime import datetime, timezone unix_milliseconds = 1715478630.0 * 1000 before = datetime.datetime.utcfromtimestamp(int(unix_milliseconds) / 1000) print('before is ', before, type(before)) after=datetime.datetime.fromtimestamp(int(unix_milliseconds) / 1000, timezone.utc).replace(tzinfo=None) print('after is None ', after, type(after)) assert before == after
## Summary & Motivation Fixes issue mentioned by @psarka Refactors method to explicitly specify timezone when converting from unix timestamp to ISO8601. Retains timezone as per existing functionality. ## How I Tested These Changes There is probably a good learning opportunity for me here. I used this snippet. Please educate me about how you want to do this properly. # convert unix timestamp at UTC at second precision to iso8601 timestamp at implicit utc of type timestamp.timestamp from datetime import datetime, timezone unix_milliseconds = 1715478630.0 * 1000 before = datetime.datetime.utcfromtimestamp(int(unix_milliseconds) / 1000) print('before is ', before, type(before)) after=datetime.datetime.fromtimestamp(int(unix_milliseconds) / 1000, timezone.utc) print('after is None ', after, type(after)) assert before == after
|
Thanks @dbrtly - I ran this through our CI which exercises these paths and did not see any issues, I think we can go ahead and merge this. |
gibsondan
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes issue mentioned by @psarka
Refactors method to explicitly specify timezone when converting from unix timestamp to ISO8601.
Subsequently retains or discards the timezone depending on existing functionality.
How I Tested These Changes
There is probably a good learning opportunity for me here. I used a snippet to validate the output was unchanged.
Please educate me about how you want to do this properly.