Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Cycle run() function to be used with @most/core #887

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

FbN
Copy link

@FbN FbN commented Jun 15, 2019

  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit

I have created a new sub-package instead of updating most-run to keep the most.js version available. (most.js and most core can be seen as two different and parallels projects).

I have never used Typescript so expect type declarations to be enhanced.

Resolved a minor type problem in isolate with hasownproperty that was blocking building

@FbN
Copy link
Author

FbN commented Jun 16, 2019

@staltz I think karma / windows 10 Chrome is broken. Tried to find a solution but I have no experience in travis/karma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant