Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearpath Heron USV #6548

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

harunkurtdev
Copy link

Description
Clearpath's USV vehicle named Heron has been added.

Tasks
Add the list of tasks of this PR.

  • New Robot

Screenshots
ocean
swarm

@harunkurtdev harunkurtdev requested a review from a team as a code owner May 11, 2024 13:01
@omichel
Copy link
Member

omichel commented May 11, 2024

There are several errors reported by the CI on the "Test Sources". In particular:

/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:29:1: W293: blank line contains whitespace
/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:46:1: W293: blank line contains whitespace
Missing ".wproj" file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/worlds/.swarm.wbproj"
Wrong line ending in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/obj/boat.obj"
missing icon: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"
Wrong header in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"

etc.

Can you please fix them?

@harunkurtdev
Copy link
Author

I fix that bugs @omichel

@omichel
Copy link
Member

omichel commented May 13, 2024

Thank you. Could you please also write a short documentation? This is required for robots distributed in Webots.

@harunkurtdev
Copy link
Author

@omichel I finish all of for document, can you check ?

projects/robots/clearpath/heron/protos/docs/heron.md Outdated Show resolved Hide resolved
Comment on lines +3 to +10
### Reliability:
Heron is known for engineering quality and durability based on Clearpath Robotics' years of experience. This allows users to perform their tasks without worrying about reliability.
### Flexibility:
Heron's modular design allows it to be configured according to users' needs and task requirements. This facilitates the integration of different sensors, equipment and loads, making it suitable for a variety of applications.
### Autonomous Capabilities:
Heron has autonomous navigation capabilities that can perform complex tasks. This ensures it can travel designated routes and complete tasks without operator intervention.
### High Performance:
Heron is a high-performance platform optimized for long-range and long-duration missions. This provides the ability to cover large areas, collect data, and be continuously active throughout the mission.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like advertising. Instead we should have here a more technical description of the robot and its features: sensors, motors, autonomy, use cases, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, I will changed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants