-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IP Type of Service #13606
base: master
Are you sure you want to change the base?
Support IP Type of Service #13606
Conversation
ddc3935
to
2c5db47
Compare
I don't know what to do with the remaining tests that fail. Can you please advise? |
Why is a new libcurl option needed? Can't |
This is a IPv4-only feature. What happens for IPv6 sockets and how is a user supposed to know when this works or not? Can you please explain your use case for this? |
We use it with the command-line interface. And if I understand correctly, |
We need it for applying QoS for IP packets. All the other parts of our application support this, and we've been patching curl for long time to add support. Now we'd like to upstream our patches (2 more will follow :)). I noticed that another used proposed a similar change in #7762, but it was abandoned. I took the user-friendly names from that PR. |
You add |
It is used in |
bcb0e25
to
1af883c
Compare
I do. I don't see why libcurl needs another option when you can already accomplish the same thing using an existing option. |
The next feature I plan to add is setting VLAN priority, which is another setsockopt ( |
So do both in the same callback? |
dce54bd
to
e6a7c46
Compare
Done. Is this what you meant? |
The failing test in |
Yes, we try to hunt that down for some time. Sorry about that. |
c290eb0
to
0d692fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also interested in this feature, so thanks for writing it up!
0cfe17e
to
23ece88
Compare
@bagder Is this good to go, now that 8.8 was released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot merge this anyway until the feature window opens on June 1st if everything goes well.
Is the msys2 with debug flaky? I couldn't find anything in the log that looks related to my changes. |
@orgads: Yes, the MSYS2 mingw-w64 ones sometimes hang in tests. I'm tracking the problem here: #13599 (comment). Could not yet figure out which test is prone to hanging though. |
Adds a
--type-of-service
option the command line tool for setting the TOS IPv4 header field.