-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: cupyx/scipy/interpolate: add griddata
#8290
base: main
Are you sure you want to change the base?
Conversation
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
Both dependencies are merged, the PR is rebased on main and is ready for review. |
/test mini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Waiting for CI pass.
Seems that CI fails with illegal memory access. Does this occurs on your local? Disabling CuPy's memory pool
|
Sadly, no, I don't see this locally. Also given that this PR only adds a thin pure python wrapper, the the root problem is likely somewhere else. Where does the error originate? |
Seems that its first occurrence in CI log is https://ci.preferred.jp/cupy.linux.cuda112/161482/
|
TBH, I don't see how a pure python addition of this PR can trigger this. The only possiblility is that a nan assignment is broken somehow, in this line: https://github.com/cupy/cupy/pull/8290/files#diff-e6ca1b203fa4c1b7e7f6170aa16844edb19aa250d65f43d99d4bd3ee26187b36R256 with the default of |
I've tried running
|
@andfoy Can I ask you to check if |
Port
griddata
function fromscipy.interpolate
. This is a pure python convenience wrapper ofLinearNDInterpolator
,NearestNDInterpolator
andCloughTocher2DInterpolator
, so no need to benchmark performance.This PR is on top of #8220 for the NearestNDInterpolator and #8289 for
interp1d
. Will need a rebase or two when these two PRs land.