Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): Add Chuanqing Zhang to be a committer. #3386

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

zhangchuanqing5658
Copy link
Collaborator

@zhangchuanqing5658 zhangchuanqing5658 commented May 21, 2024

Fixes: no

Main Issue: no

Motivation

I contributed a lot of code to the CubeFS. I want to add myself(Chuanqing Zhang) as a committer to do more things.

In the future, I would first like to see the project code improve stability and security by continuously optimizing legacy issues. Then I will consider improving its performance and scalability, for example by providing support for rdma to improve communication performance, by providing support bitmap ino allocator, by providing support rocksdb instead btree in metanode.

rocksdb branch:https://github.com/cubefs/cubefs/tree/metanode_rocksdb (This branch has already been merged into the rocksdb development branch : https://github.com/cubefs/cubefs/tree/metanode_rocksdb_dev)
raft rdma branch:https://github.com/cubefs/cubefs/tree/online_0701_verbs_server

Modifications

Update the maintainers documentation.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • So on...

Verifying this change

  • Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • This can be verified in development debugging
  • This can be realized in a mocked environment, like a test cluster consisting in docker

(or)

This change MUST reappear in online clusters, or occur in that specific scenarios.

Does this pull request potentially affect one of the following parts:

  • Master
  • MetaNode
  • DataNode
  • ObjectNode
  • AuthNode
  • LcNode
  • Blobstore
  • Client
  • Cli
  • SDK
  • Other Tools
  • Common Packages
  • Dependencies
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Review Expection

  • in-two-days
  • weekly
  • free-time
  • whenever

Matching PR in forked repository

PR in forked repository:

Signed-off-by: zhangchuanqing1 <zhangchuanqing1@jd.com>
Copy link

netlify bot commented May 21, 2024

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 4594bad
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/664c7d27c818ac0008632e9d
😎 Deploy Preview https://deploy-preview-3386--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mervinkid mervinkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@leonrayang leonrayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonrayang
Copy link
Member

+1

1 similar comment
@mervinkid
Copy link
Member

+1

@xiaochunhe xiaochunhe self-requested a review May 22, 2024 06:12
Copy link
Contributor

@xiaochunhe xiaochunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,LGTM

@mervinkid
Copy link
Member

+1

1 similar comment
@bladehliu
Copy link
Member

+1

@leonrayang leonrayang merged commit dacb598 into master May 22, 2024
23 checks passed
@leonrayang leonrayang deleted the zhangchuanqing branch May 28, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants