Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(master): change ip address of nodes including masternode, metanode and datanode #3268

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hooklee2000
Copy link
Contributor

@hooklee2000 hooklee2000 commented Mar 18, 2024

Fixes: #3120

Motivation

change ip address of nodes including masternode, metanode and datanode

Modifications

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • So on...

Verifying this change

  • Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Master
  • MetaNode
  • DataNode
  • ObjectNode
  • AuthNode
  • LcNode
  • Blobstore
  • Client
  • Cli
  • SDK
  • Other Tools
  • Common Packages
  • Dependencies
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Review Expection

  • in-two-days
  • weeks
  • free-time
  • whenever

Matching PR in forked repository

enter the url if has PR in forked repository.


PR in forked repository:

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 91a4f25
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/662728ac28d1dc000864b9cf
😎 Deploy Preview https://deploy-preview-3268--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hooklee2000 hooklee2000 changed the title change ip address of nodes including masternode, metanode and datanod… feat: change ip address of nodes including masternode, metanode and datanode Mar 18, 2024
Signed-off-by: hooklee2000 <hooklee2000@gmail.com>
Signed-off-by: hooklee2000 <hooklee2000@gmail.com>
@hooklee2000 hooklee2000 changed the title feat: change ip address of nodes including masternode, metanode and datanode feat(metanode,datanode): change ip address of nodes including masternode, metanode and datanode Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 5.07246% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 41.87%. Comparing base (bdffd66) to head (4400c05).
Report is 14 commits behind head on master.

❗ Current head 4400c05 differs from pull request most recent head 91a4f25. Consider uploading reports for the commit 91a4f25 to get more accurate results

Files Patch % Lines
master/api_service.go 0.00% 69 Missing ⚠️
master/cluster.go 1.58% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
+ Coverage   40.49%   41.87%   +1.37%     
==========================================
  Files         603      581      -22     
  Lines      125057   119940    -5117     
==========================================
- Hits        50643    50220     -423     
+ Misses      70051    65404    -4647     
+ Partials     4363     4316      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hooklee2000 hooklee2000 changed the title feat(metanode,datanode): change ip address of nodes including masternode, metanode and datanode feat(meta,datanode): change ip address of nodes including masternode, metanode and datanode Mar 18, 2024
@hooklee2000 hooklee2000 changed the title feat(meta,datanode): change ip address of nodes including masternode, metanode and datanode feat(master): change ip address of nodes including masternode, metanode and datanode Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: change ip address of nodes including masternode, metanode and datanode
1 participant