-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn in rolling window pages that Redshift does not support month or year intervals #8252
base: master
Are you sure you want to change the base?
Conversation
Please note that Redshift does not support intervals of type month or year.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
Please note that Redshift does not support intervals of type month or year.
<WarningBox> | ||
|
||
Please note that Redshift does not support intervals of type month or year. | ||
|
||
</WarningBox> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morgan-at-cube I don't think we need to put this warning on this particular page. If we do, then we'd probably need to have it at every page mentioning rolling_window
which is probably not the way to go.
<WarningBox> | ||
|
||
Please note that Redshift does not support intervals of type month or year. | ||
|
||
</WarningBox> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morgan-at-cube Do we know how it breaks? E.g., what is the exact error message?
I think we can probably do the following:
- Add the error message and the note on the Redshift data source page.
- Have a more generic note on this page, e.g., "There are known limitations for
rolling_window
support when using Redhsift (link to the data source page)". It's gonna be more extendable this way.
Add warning box to two pages: Please note that Redshift does not support intervals of type month or year.
Context: https://cubedevinc.slack.com/archives/C021C7NT7RT/p1715293531642229
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]