Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boehmgc package from nixpkgs in shell.nix #14591

Conversation

straight-shoota
Copy link
Member

This is largely a simplification. I don't think we need to build our own derivation of the GC when there's already a generic one in nixpkgs. With overrides we get almost the same configuration as our custom build.
The custom build was previously necessary because we required unreleased patches.
That's gone now and we should be fine with any recent upstream version.

Most significant changes as far as I can see are some compile flags are gone:

@straight-shoota straight-shoota self-assigned this May 13, 2024
@straight-shoota straight-shoota changed the title Use upstream boehmgc package with overrides Use boehmgc package from nixpkgs with overrides May 13, 2024
@straight-shoota straight-shoota changed the title Use boehmgc package from nixpkgs with overrides Use boehmgc package from nixpkgs in shell.nix May 13, 2024
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I liked about the previous state is that jumping to a patched gc version was easier :-)

@straight-shoota straight-shoota added this to the 1.13.0 milestone May 13, 2024
@straight-shoota straight-shoota merged commit 0e96b0a into crystal-lang:master May 15, 2024
61 checks passed
@straight-shoota straight-shoota deleted the infra/shell.nix-upstream-gc-package branch May 15, 2024 08:19
@mamantoha
Copy link
Contributor

Hi @straight-shoota . Could this change be related to the issue with crystal-lang/install-crystal GitHub Action that causes an error with Crystal Nightly? Check this link for an example.

image

@straight-shoota
Copy link
Member Author

No, that's completely unrelated. The installer issue was caused by crystal-lang/distribution-scripts#300 and is already fixed (#14594). Unfortunately, today's nightly build is broken for yet another reason, but should be fixed shortly by #14595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants