Use boehmgc
package from nixpkgs in shell.nix
#14591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a simplification. I don't think we need to build our own derivation of the GC when there's already a generic one in nixpkgs. With overrides we get almost the same configuration as our custom build.
The custom build was previously necessary because we required unreleased patches.
That's gone now and we should be fine with any recent upstream version.
Most significant changes as far as I can see are some compile flags are gone:
--disable-debug
: Not sure if there's any particular reason for this.--disable-dependency-tracking
: There seems to be a reason to use this for building unified binaries on macOS. https://github.com/ivmai/bdwgc/blob/b1fe06200d716cd63d3ec321654fb4d03d610240/docs/platforms/README.darwin#L9I don't think this is necessary for a development environment, so it's probably fine to drop it.
--disabled-shared
should not be necessary. We could setenableStatic
instead but I don't think that's necessary for a development environment.