Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: w3c schema endorsement #717

Merged
merged 18 commits into from
May 23, 2024
Merged

feat: w3c schema endorsement #717

merged 18 commits into from
May 23, 2024

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Implemented w3c schema request endorsement functionality
  • Implemented w3c schema submit endorsementfunctionality
  • Modified sign transaction functionality according to schema type

Why?

  • To allow and ensure that the system can handle W3C schema requests and submissions properly.
  • Sign transaction functionality is for to correctly differentiates between different schema types to apply appropriate processing logic.

@bhavanakarwade
feat: request w3c schema endorsement
b71cc0b 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into fe…
b0e9346 
…at/w3c-schema-endorsement
@bhavanakarwade
feat: implemented w3c schema submit functionality
ccc271c 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
fix: resolve conflicts
035f178 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
feat: refactored sign endorsement transaction functionality
4c3ec87 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into fe…
9c1b08d 
…at/w3c-schema-endorsement
@bhavanakarwade
fix: removed unnecessary codes
bd0a7a2 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
fix: resolved conflicts
77e701b 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
refactor: cred def endorsement sign and submit functionality
95e590d 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into fe…
3c151fc 
…at/w3c-schema-endorsement
@bhavanakarwade bhavanakarwade self-assigned this May 16, 2024
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label May 16, 2024
@bhavanakarwade bhavanakarwade linked an issue May 16, 2024 that may be closed by this pull request
feat: W3C Schema endorsement #696
Open
7 tasks
@bhavanakarwade
fix: resolved sonarlint issues
bfc02f4 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
fix: improve error handling
2ad2d9d 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
reafactor: schema validator function
3941c9c 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
fix: resolved conflicts
680239a 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
reafctor: apply class validator
86d68a2 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Base automatically changed from develop to qa May 17, 2024 10:02
@bhavanakarwade bhavanakarwade changed the base branch from qa to develop May 21, 2024 07:12
tipusinghaw
tipusinghaw reviewed May 22, 2024
View reviewed changes
apps/api-gateway/src/ecosystem/dtos/request-schema.dto.ts Show resolved Hide resolved
apps/api-gateway/src/ecosystem/ecosystem.service.ts Outdated Show resolved Hide resolved
apps/api-gateway/src/schema/schema.controller.ts Show resolved Hide resolved
apps/ecosystem/enums/ecosystem.enum.ts Outdated Show resolved Hide resolved
apps/ecosystem/interfaces/ecosystem.interfaces.ts Outdated Show resolved Hide resolved
apps/ecosystem/src/ecosystem.service.ts Outdated Show resolved Hide resolved
apps/ecosystem/src/ecosystem.service.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.service.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.service.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.service.ts Outdated Show resolved Hide resolved
@bhavanakarwade
fix: resolved comments on pr
efd9e9f 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into fe…
fc1a9b4 
…at/w3c-schema-endorsement
KulkarniShashank
KulkarniShashank approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bhavanakarwade bhavanakarwade merged commit 57debc4 into develop May 23, 2024
1 check passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: W3C Schema endorsement
3 participants
@bhavanakarwade @KulkarniShashank @tipusinghaw