Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to get credDef for schemaId with surrounding spaces #710

Merged
merged 2 commits into from
May 16, 2024

Conversation

GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented May 7, 2024

What

  • Added transform pipe to trim spaces surrounding schemaId

Why

  • Fixes unable to get credDef for schemaId with surrounding spaces (issue #405)

…a Id

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna self-assigned this May 7, 2024
@GHkrishna GHkrishna changed the title fix: triming issues while getting all credential definitions by schem… fix: unable to get credDef for schemaId with surrounding spaces May 7, 2024
Copy link
Contributor

@pranalidhanavade pranalidhanavade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GHkrishna GHkrishna requested review from bhavanakarwade and removed request for KulkarniShashank May 16, 2024 13:08
Copy link
Contributor

@bhavanakarwade bhavanakarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@GHkrishna GHkrishna merged commit e3dfbd3 into develop May 16, 2024
1 check passed
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GHkrishna GHkrishna deleted the fix/get-verification-by-schemaId branch May 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants