This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
CQF-1271, 1280 fix test cases #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsetriboulders
changed the title
|
This PR duplicates effort in #560, not sure if that's intended or not. The source of the xml tests in the cql-engine repo is actually the CQL specification IG here: https://github.com/HL7/cql/tree/master/tests/cql If there are tests that are incorrectly specified they should be fixed in the CQL spec (i.e. edit the XML there) and we'll propagate that to the cql-engine repo. I looked through the tests and the only one I'm certain that's wrong is It doesn't look to me like the other changes are correct. Those appear to me to be bugs in the cql-engine, and therefore there should be cql-engine changes to fix that as opposed to bugs in the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.