Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Feature test cql #562

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

echicoine-icf
Copy link

Please review changes made for DateTime comparison. Current DateTime comparison changes date passed in and never passes based on expected output demonstrated by the tool. The modified approach checks for instanceof DateTime then utilizes simple toString() for left/right comparison.

@JPercival
Copy link
Contributor

The source for this test is actually the CQL specification repo here:
https://github.com/HL7/cql/blob/master/tests/cql/CqlTypeOperatorsTest.xml

If there are flaws in the test specification lets fix them in the upstream repo.

Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely not be changing datetime comparison to use string conversion for equality, what drove this change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants