Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add preproc workflow for anat with several sessions #1191

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces an enhancement to the preprocessing workflow for anatomical images with several sessions. It includes updates to the Makefile for data retrieval from OpenNeuro datasets and modifications to a Python script for creating dummy datasets to accommodate multiple sessions.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the increase in parallelism for data retrieval commands is well-tested on the target hardware to prevent potential performance bottlenecks.
  • Consider removing or documenting the commented-out lines for 'func' and 'fmap' data retrieval to maintain code clarity and avoid confusion.
  • Verify that the changes made are consistent with the intended use cases and that they do not introduce any unintended side effects.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

demos/openneuro/Makefile Show resolved Hide resolved
demos/openneuro/Makefile Show resolved Hide resolved
demos/openneuro/Makefile Show resolved Hide resolved
@Remi-Gau
Copy link
Contributor Author

probably worth considering a separate workflow to process anat separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant