Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting calendar redesign #862

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

NIDHI2023
Copy link
Contributor

Summary

Implements Lucy's design changes for the exporting Google/Apple calendar feature.

  • Got rid of bookmark
  • Changed TA unfinished indicator to be a red dot when there is someone in "Ahead"

image

image

Redesigned modal:

  • Buttons are now vertical
  • Functionality is the same
  • Got rid of repeating office hour title, now is just course code and OH name
  • Added date and time as subtitle

image

With overflowing text:

image

Test Plan

  • Change the "Ahead" number of students and make sure red dot appears when there is at least one, otherwise should go away
  • Make sure Calendar Export modal shows expected name, date, and times for any office hour
  • Check if styling remains consistent for long OH names
  • Check if buttons work as expected

Notes

  • Added dependency (ran yarn add @mui/icons-material)

Breaking Changes

None

Checklist

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@NIDHI2023 NIDHI2023 requested a review from a team as a code owner May 4, 2024 19:22
@dti-github-bot
Copy link
Member

dti-github-bot commented May 4, 2024

[diff-counting] Significant lines: 262.

Copy link
Contributor

@stevenyuser stevenyuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nidhi, the redesign looks pretty good! I think the design very closely matches Lucy's Figma designs and looks a lot better than the previous version.

I have some minor suggestions/bugs:

  • There's a CSS error when the location of the OH session is two lines
image
  • When clicking "Add to GCal", I think it should open a GCal link on a new tab instead of opening the GCal link on the same tab. One way to do this is by changing your current GCal Button from this:
<Button href={getGoogleCalendarLink()} className="export-btn" >
    <Button.Content icon>
        <Icon name='google' />
        Add to GCal
    </Button.Content>
</Button>

to this:

<Button
    onClick={() => window.open(getGoogleCalendarLink(), "_blank")}
    className="export-btn"
>
    <Button.Content icon>
        <Icon name="google" />
        Add to GCal
    </Button.Content>
</Button>

Other than that, everything looks great! Good job!

Copy link
Contributor

@burninglilies burninglilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nidhi! Great work on this speedy PR. Aside from Stevens suggestion about opening Calendar in new tab and trying to make Session names one line I just have one more suggestion. Since we are no longer using the bookmark icon nor Google or Apple Icon it would also be a good to remove them from our media as well if they are not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants