-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting calendar redesign #862
base: master
Are you sure you want to change the base?
Conversation
-need to test if bookmark goes away and indicator shows up when qs is created for empty que
-need to do further testing -long titles should work
[diff-counting] Significant lines: 262. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nidhi, the redesign looks pretty good! I think the design very closely matches Lucy's Figma designs and looks a lot better than the previous version.
I have some minor suggestions/bugs:
- There's a CSS error when the location of the OH session is two lines
- When clicking "Add to GCal", I think it should open a GCal link on a new tab instead of opening the GCal link on the same tab. One way to do this is by changing your current GCal Button from this:
<Button href={getGoogleCalendarLink()} className="export-btn" >
<Button.Content icon>
<Icon name='google' />
Add to GCal
</Button.Content>
</Button>
to this:
<Button
onClick={() => window.open(getGoogleCalendarLink(), "_blank")}
className="export-btn"
>
<Button.Content icon>
<Icon name="google" />
Add to GCal
</Button.Content>
</Button>
Other than that, everything looks great! Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nidhi! Great work on this speedy PR. Aside from Stevens suggestion about opening Calendar in new tab and trying to make Session names one line I just have one more suggestion. Since we are no longer using the bookmark icon nor Google or Apple Icon it would also be a good to remove them from our media as well if they are not being used.
Summary
Implements Lucy's design changes for the exporting Google/Apple calendar feature.
Redesigned modal:
With overflowing text:
Test Plan
Notes
Breaking Changes
None
Checklist