-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter admin courses #825
base: master
Are you sure you want to change the base?
Filter admin courses #825
Conversation
-need to distinguish for "other" semesters - need to keep archived section only for default page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks great, thanks for getting this working so quickly! This will definitely help us navigate the admin page a lot more easily.
Could you also mention in the PR description the dependency changes you made? e.g. the commands you may have run to change what's in the yarn.lock file. Some changes like using sass instead of node-sass were already merged into master, so I just want to double check that the dependencies are correct. Also, be sure to resolve merge conflicts and the pipeline failing issues (lmk if you need help with either of those, might be confusing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll also add more code comments sometime tomorrow + we'll loop in the designers to see if they have any suggestions.
[diff-counting] Significant lines: 62. |
…ffice-hours into nidhi/filter-admin-courses (increased width and changed filter background)
Summary
Dependency Changes:
Test Plan
-Check if all the desired semesters are available in the dropdown
-Check if the admin page loads the expected default semester, and the archived courses are only visible for this semester
-Check if the correct courses are displayed for each semester
-Check if the "Other" category displays any extraneous courses
-Check if creating a new course while the courses are in their filtered display properly shows up
Checklist