-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Export #803
base: master
Are you sure you want to change the base?
CSV Export #803
Conversation
[diff-counting] Significant lines: 716. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Steven, great progress on this task since the last time I saw it at work session – sorry for the slow turnaround for code reviews recently. You've made quick progress on this, and the functionality looks good overall – no issues with the frontend at all. A few comments:
- The average wait time is off by a bit (is this rounded?). When I tested it, the question was answered ~1 minute after it was added.
That's all the suggestions I have for now. We can talk more during work session about these things + future changes. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think you may have attached the wrong demo recording lol
Hi Richard, I finished the date picker and addressed the other bugs/fixes as well! |
Summary
Demo:
https://github.com/cornell-dti/office-hours/assets/77898813/5e34b649-523b-4872-a9d0-f0c0c52fc7e0
Screenshot:
Documentation:
Test Plan
Notes
Future changes
Breaking Changes
None