Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export #803

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

CSV Export #803

wants to merge 23 commits into from

Conversation

stevenyuser
Copy link
Contributor

Summary

  • in professor dashboard, added option to let staff export queue data/statistics on sessions
    • the user can select which statistics to export
  • The queue data is downloaded on the user's local computer as a CSV file

Demo:
https://github.com/cornell-dti/office-hours/assets/77898813/5e34b649-523b-4872-a9d0-f0c0c52fc7e0

Screenshot:
image

Documentation:

  • relevant documentation is in code (ExportCSV.tsx)

Test Plan

  • Check that the exported data matches the firebase data
  • Check that only the selected analytics get exported to the CSV file

Notes

Future changes

  • Need to add a date picker once QMI's material-ui library is updated to v5 (and material-ui x-date-pickers v5 is added to dependencies), right now only selecting by semester works (the date picker option is just a placeholder)
  • Implement exporting rating analytics after rating feature is merged into main branch and ready

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@stevenyuser stevenyuser requested a review from a team as a code owner March 1, 2024 22:54
@dti-github-bot
Copy link
Member

dti-github-bot commented Mar 1, 2024

[diff-counting] Significant lines: 716.

Copy link
Contributor

@rgu0114 rgu0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Steven, great progress on this task since the last time I saw it at work session – sorry for the slow turnaround for code reviews recently. You've made quick progress on this, and the functionality looks good overall – no issues with the frontend at all. A few comments:

  1. The average wait time is off by a bit (is this rounded?). When I tested it, the question was answered ~1 minute after it was added.
Screen Shot 2024-03-14 at 3 05 14 PM 2. This data was nice to see! Small nit though, there's several NaNs so let's have that default to something more user friendly Screen Shot 2024-03-14 at 3 07 46 PM 3. Could you investigate why the TA names/net IDs are blank in some spots? It's hard to identify as a professor if it's bc it's the same TAs as previous sessions or there's some issue. 4. I see that you're holding off on adding the date picker for now. I don't quite remember what we discussed – were you able to find reasonable options from other libraries, or should we upgrade to MUI v5 first?

That's all the suggestions I have for now. We can talk more during work session about these things + future changes. Great work!

Copy link
Contributor

@rgu0114 rgu0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think you may have attached the wrong demo recording lol

@rgu0114 rgu0114 mentioned this pull request Mar 15, 2024
2 tasks
@stevenyuser
Copy link
Contributor Author

Hi Richard, I finished the date picker and addressed the other bugs/fixes as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants