Redesigned the Add/Edit Student Modal #511
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the styling of the Add/Edit Student Modal to reflect design by Lazim. Changed first and last name fields to just a name field and extracted the first and last name to submit to html form.
The code to extract the first and last name from one name field I took from this PR#425 by Desmond.
I still need to redesign the other multiselect needs box and the svg image for the calenders should be gray to reflect Lazim's designs.
What it looks like
Here, the correct error for an empty name shows up
Here you can see everything filled in and that I still need to style the multiselect accessibility dropdown
You can see that the first and last name was extracted correctly. Although I wasn't able to make the request to the server because of a 500.
Here is my error when trying to add a new student to the server
This pull request is the first step towards redesigning the Add / Edit Student Modal.
Test Plan
I tested the design on multiple screensizes and it seems to be working correctly
For testing the backend, I need to figure out how to connect to the server and finish the multiselect for needs to test everything.