Added a search bar and filter box in the Locations page #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y -Isn't responsive enough, flashes everytime you select or deselect an option -One bug is that you can't deselect the last element
…ed filtering for specific tags yet
|
[diff-counting] Significant lines: 75. |
Atikpui007
previously approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Pretty good PR. Search functionality works as expected and tags also work as expected. Will merge this but will have to change the dropdown to use the react-select library.
Great job
Lol and also hop on a huddle lets figure out what the issue with prettier is
| const loc = useLocations().locations; | ||
|
|
||
| useEffect(() => { | ||
| setLocations(loc); | ||
| setSearchLocations(loc); | ||
| }, [loc]); |
There was a problem hiding this comment.
Good job here! A lot of people forget to add the dependency array when using useEffect and its a huge pain lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a search bar based on name of location and filter box for filtering by tags in the Locations Page.
The search functionality is just checking if the string in the search bar is contained in the names of the location. If yes then it displays it in the table below.
The filter box filters the locations by tags. If None is chosen then it filters nothing.
Here is both of them working together:
screen-capture.webm
Test Plan
I have so far tested it manually and everything seems to work. I honestly don't know how to test it more rigorously, so any feedback in this area is greatly appreciated.
Notes
I couldn't find any figma designs of the filter box, so I just decided to give it the minimum amount of styling.