Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Needs entry to student when selecting "other" #497

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

namanhboi
Copy link
Contributor

@namanhboi namanhboi commented Mar 3, 2024

Summary

Added an input field that appears below the "Needs" drop downbox when "Other" is selected to student. It doesn't update the database and is for just appearance.

image
When "Other" is not selected

image
When "Other" is selected

Tested on different screen sizes (mobile, desktop) and no bugs have been spotted.

  • implemented the textbox when other is selected.

Test Plan

No plans currently as it doesn't update the database or have any bugs.

Notes

Breaking Changes

None.

@namanhboi namanhboi requested a review from a team as a code owner March 3, 2024 19:43
@dti-github-bot
Copy link
Member

dti-github-bot commented Mar 3, 2024

[diff-counting] Significant lines: 15.

@namanhboi namanhboi changed the title Added input form when other is selected in needs dropdown Add Needs entry to student when selecting "other" Mar 3, 2024
Copy link
Contributor

@selenaliu1 selenaliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. My only suggestion would be to add a label like "Please Specify" so that it is very clear what the input field is for.

@namanhboi
Copy link
Contributor Author

Overall this looks good to me. My only suggestion would be to add a label like "Please Specify" so that it is very clear what the input field is for.

I just added the placeholder text, thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants