Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unscheduled rides are now expanded by default #496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raissaji
Copy link
Contributor

@raissaji raissaji commented Mar 3, 2024

Summary

This pull request ensures that the "Unscheduled Rides" dropdown is expanded by default.

Test Plan

Screen Shot 2024-03-03 at 12 06 27 AM

Notes

The "Unscheduled Rides" dropdown for every date are not independent states. For example, if I un-expand the dropdown for March 21th, and then click on March 4th, the latter's dropdown will be unexpanded instead of defaulting to its expanded state.

Screen Shot 2024-03-03 at 12 05 55 AM

I unexpand "Unscheduled Rides" on March 21

Screen Shot 2024-03-03 at 12 06 03 AM

When I go back to March 4, it remains unexpanded

@raissaji raissaji requested a review from a team as a code owner March 3, 2024 05:14
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 2.

@namanhboi
Copy link
Contributor

Short and simple changes, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants