Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit log message on rest client exception #2935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Integer93
Copy link

Logging the whole avro-schema could lead to very large log messages. In our case we generated many 16 KB logs.

I would propose to not log the whole schema to avoid that risk.

No longer logging the whole schema on a restClientException
@Integer93 Integer93 requested a review from a team as a code owner January 19, 2024 14:06
Copy link

cla-assistant bot commented Jan 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Jan 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ollio
Copy link

ollio commented Jan 19, 2024

This should fix #2936 but it would be nice to add the schema name and ID to the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants