Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elect leader api(KIP-460) implemented #2220

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

PratRanj07
Copy link
Member

Implemented the Elect Leaders API(KIP - 460) and wrote unit tests for it.

The build is gonna fail until the ElectLeaders api is merged in ibrdkafka.

Done the local testing and unit testing locally and getting desired results

`dotnet run localhost:9092 elect-leaders 0 Test1 0

One or more elect leaders operations failed.
An error occurred in elect leaders operation in Topic Test1 Partition [0]: Code: ElectionNotNeeded, Reason: Leader election not needed for topic partition.`

which is the desired result in case Leader Election is not required in the partitions.

Unit tests also ran fine.

`dotnet test --filter "FullyQualifiedName~Confluent.Kafka.UnitTests.ElectLeadersErrorTests"

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed! - Failed: 0, Passed: 5, Skipped: 0, Total: 5, Duration: 2 s - Confluent.Kafka.UnitTests.dll (net6.0)`

Copy link

cla-assistant bot commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented May 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PratRanj07 PratRanj07 requested review from anchitj and removed request for jainruchir May 16, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant