Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize compatibility checks #16251

Open
wants to merge 9 commits into
base: develop2
Choose a base branch
from

Conversation

RubenRBS
Copy link
Member

Changelog: Feature: Parallelize compatibility checks (up to x3 speedup)
Docs: Omit

I pulled the current thread count out of thin air after testing some values locally, but as with everything having to do with concurrency, nothing is a best fit for everyone

@RubenRBS RubenRBS added this to the 2.4.0 milestone May 14, 2024
@sykhro
Copy link

sykhro commented May 19, 2024

Is this tweaked by tools.build:jobs? Some of us use high core-count build machines (> 64 cores). Being able to adjust these parameters is very helpful, you never know where the bottleneck truly is

@RubenRBS
Copy link
Member Author

Hi @sykhro thanks a lot for checking the PR out. After discussing it with the team, we'll start with just creating a small ThreadPool of say 8, and leave the configuration for a later date.

This is mostly because we find the UX could get a bit ugly and some questions were raised as to whether we could harmonize it with the rest of the parallel confs :)

conans/client/graph/graph_binaries.py Outdated Show resolved Hide resolved
conans/util/thread.py Outdated Show resolved Hide resolved
@memsharded memsharded self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants