-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CheckPlatformReqsCommand Test #11079
base: main
Are you sure you want to change the base?
Conversation
'composerJson' => [ | ||
'require' => [ | ||
'first/pkg' => '^2.0', | ||
'second/pkg' => '3.*', | ||
], | ||
'require-dev' => [ | ||
'dev/pkg' => '~2.0', | ||
], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lots of duplication and cruft as these are entirely unnecessary to run this test. Would be nice to reduce duplication at least.
'composerJson' => [ | ||
'require' => [ | ||
'first/pkg' => '^2.0', | ||
'second/pkg' => '3.*', | ||
], | ||
'require-dev' => [ | ||
'dev/pkg' => '~2.0', | ||
], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of duplication here too, and it doesn't seem to provide much value as you only check the first line of output.
It'd be more valuable to actually check behavior i.e. make sure that the installed packages above in testCheckPlatformReqs have some requirements on platform and then check that the output is pass or fail depending if it's a valid requirement or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will work on that.
No description provided.