Replace incorrect quotes #3833
Open
Replace incorrect quotes #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use single quote instead of double quote Regex used: %s/^\(\c[a-zàèéíòóúüï]\)"\(\c[a-zàèéíòóúüï]\)/\1'\2/ %s/ \(\c[a-zàèéíòóúüï]\)"\(\c[a-zàèéíòóúüï]\)/ \1'\2/g
|
Hi @galcorlo, have you checked to see which of these sentences already have recordings, or do none of them have recordings? |
|
Hi @ftyers, I downloaded the dataset and I could verify that at least some sentences are there. Having theses sentences with incorrect quotes is not an bloker because the person who is recording his own voice is probably able to fix it, but it's true he has to pay more attention before start to record and probably he has to read the sentence two times, as it happened to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
Acknowledging contributors