Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step8.png/training: Updated img to reflect current UI #32481

Closed
wants to merge 2 commits into from

Conversation

ugtthis
Copy link
Contributor

@ugtthis ugtthis commented May 20, 2024

Problem

Old step8.png has outdated UI and the white car in the middle is bright and draws attention

OLD-step8

Solution

New photo with the current UI and a slightly blurred background to increase focus on comma device. The boundingRect which is the clickable area to proceed to the next screen will still work with the new image when going through the training flow since boundingRect goes around comma device screen. The new photo is 331KB while the old photo is 729KB

NEW-step8


Comparing old vs new

old-vs-new.mp4

Copy link
Contributor

github-actions bot commented May 20, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@ugtthis
Copy link
Contributor Author

ugtthis commented May 21, 2024

Closing and reopening PR to trigger CI

@ugtthis ugtthis closed this May 21, 2024
@ugtthis ugtthis reopened this May 21, 2024
@adeebshihadeh
Copy link
Contributor

Thanks for the PR, but I'm going to have to close due to https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-doesnt-get-merged. Looks pretty good though!

@ugtthis ugtthis deleted the update-training-step8-img branch May 22, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants