Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Pass/Fail Customization #777

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

maitrayshah-cb
Copy link
Contributor

@maitrayshah-cb maitrayshah-cb commented Dec 21, 2022

Currently Salus only allows pass/fail based on if vulnerabilities are found or are not found. We want to expand this by allowing for more customization, mainly the following -

  • By ID: We want scan to fail only for certain vulnerability IDs. For example: A scan should only fail if CVE-123 is found but will pass if CVE-XYZ is found.
  • By Severity: We want scan to fail for a particular severity. For example: A scan should only fail if critical vulnerabilities are found but pass if low / medium vulnerabilities are found.

Scanner Config by ID

scanner_configs:
  BundleAudit:
    exceptions:
      - advisory_id: CVE-2020-26945
        changed_by: security-team
        notes: Currently no patch exists and determined that this vulnerability is not exploitable.
        expiration: "2022-12-31"
    rule:
      type: id
      matches:
        - key: CVE-123
        - key: CVE-XYZ

Scanner Config by Severity

scanner_configs:
  GoOSV:
    exceptions:
      - advisory_id: CVE-2020-26945
        changed_by: security-team
        notes: Currently no patch exists and determined that this vulnerability is not exploitable.
        expiration: "2022-12-31"
    rule:
      type: severity
      matches:
        - key: critical
        - key: high

@maitrayshah-cb maitrayshah-cb marked this pull request as draft December 21, 2022 21:09
@maitrayshah-cb maitrayshah-cb changed the title Customize salus yaml Allow Pass/Fail Customization Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant