Fix Enforced Scanner Bug #742
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikat056
previously approved these changes
Nov 15, 2022
|
@maitrayshah This pr requires a rebase |
|
Gonna hold off on this one, since this changed default behavior. |
cb-heimdall
dismissed
saikat056’s stale review
Approved review 1181194609 from saikat056 is now dismissed due to new commit. Re-request for approval.
andrew-booth-cb
force-pushed
the
fix-enforced-scanner-bug
branch
from
06e7660
to
274db96
Compare
andrew-booth-cb
force-pushed
the
master
branch
from
1d09854
to
e927762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, certain scanners are treated as
enforcedeven when they are not specified asenforcedbecause of how default config is merged with user config. This PR changes the default config to not make any scanner asenforced.