Yarn Auto Fix - Use Recommended Patch Version #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikat056
reviewed
Sep 21, 2022
| @@ -79,7 +79,7 @@ def update_package_definition(blocks, parts) | |||
| updated_resolved = "resolved " + '"' + fixed_package_info["data"]["dist"]["tarball"] \ | |||
| + "#" + fixed_package_info["data"]["dist"]["shasum"] + '"' | |||
| updated_integrity = "integrity " + fixed_package_info['data']['dist']['integrity'] | |||
| updated_name = package_name + "@^" + version_to_update_to | |||
| updated_name = package_name + "@^" + versions.first[:patch].tr(">=", "").tr(">", "") | |||
There was a problem hiding this comment.
Can we add some unit tests for this change?
andrew-booth-cb
force-pushed
the
default-to-yarn-recommended-version
branch
from
889afa3
to
20a83c6
Compare
andrew-booth-cb
force-pushed
the
master
branch
from
1d09854
to
e927762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly use patch version return by yarn audit.