Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #122: support perforce - first part #123

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

stardust85
Copy link
Contributor

parsing of p4 command and get_changesets partially works. Tests work. I run them this way:

PYTHONPATH=. python vcs/tests/test_p4.py

@stardust85 stardust85 changed the title P4 Issue #123: support perforce - first part Jan 7, 2016
@stardust85 stardust85 changed the title Issue #123: support perforce - first part Issue #122: support perforce - first part Jan 7, 2016
@stardust85
Copy link
Contributor Author

The travis error message is strange, it doesn't look like it is caused by my changes. It fails much earlier.


Added properties:

``time``
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a standard field for this? This way it will not be possible to use my_changest.time regardless of my_changest's type (P4Changeset vs GitChangest vs HgChangeset)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We implemented date as a base for all 3 vcs-es.

@stardust85
Copy link
Contributor Author

Any update on this pull request? Is there anything I can help with?

I don't want to be out of sync with you guys for long time so our branches don't diverge too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants