Issue 19659 fix 3b #20650
Open
Issue 19659 fix 3b #20650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First approach to see the problem of wrapping words in different languages
Solution 1 with wrapping failing on Korean languages
Same languages like Spanish has space (32) as word separator. Other like Chinese has no separator. The current implementation based the decision of which char is a word separator on the location of the device. Some games let the user decide the language from a settings, so it is good to let them th choice. CJK unicodes has a len of 3 or more. I added these option for the developer to choose from: WordSeparatorBasedOnDevice: current implementation WordSeparatorSpaceSlashNotHighUnicode: Spaces and '-' will be consider words separators. Recommended for Korean WordSeparatorSpaceSlashAndKCJ: Spaces, '-' and KCJ unicodes will be consider words separators. Recommended for Spanish You can see the test on: Node:UI > GUI Dynamic Create Test > RichTest Test > language The fnction findSplitPositionForWord receives the parameter wordSeparatorMode and chooses the inlinen function (charWrappableFunctionPointer) to be use in getNextWordPos and then in std::find_if to look for a good spot to but the sentence.
|
Original issue #19659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation based the decision of which char is a word separator on the location of the device but some games let the user decide the language from a settings, so it is good to let them the choice.
I added these option for the developer to choose from:
WordSeparatorBasedOnDevice:current implementationWordSeparatorSpaceSlashNotHighUnicode:Spaces and '-' will be consider words separators. Recommended for KoreanWordSeparatorSpaceSlashAndKCJ:Spaces, '-' and KCJ unicodes will be consider words separators. Recommended for SpanishYou can see the test on:
Node:UI > GUI Dynamic Create Test > RichTest Test > language
The function findSplitPositionForWord receives the parameter wordSeparatorMode and chooses the inline function (
charWrappableFunctionPointer) to be use ingetNextWordPosand then instd::find_ifto look for a good spot to but the sentence.To make the decision I use these facts: