Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: run sequelize on insecure mode and default sql port #124053

Merged
merged 1 commit into from May 13, 2024

Conversation

DarrylWong
Copy link
Contributor

@DarrylWong DarrylWong commented May 13, 2024

The test suite expects insecure connections and that the SQL
port is on 26257.

Fixes: none
Release note: none
Epic: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong DarrylWong requested a review from a team May 13, 2024 17:08
@DarrylWong DarrylWong marked this pull request as ready for review May 13, 2024 17:09
@DarrylWong DarrylWong requested review from a team as code owners May 13, 2024 17:09
@DarrylWong DarrylWong requested review from nameisbhaskar and vidit-bhat and removed request for a team May 13, 2024 17:09
@DarrylWong DarrylWong marked this pull request as draft May 13, 2024 17:11
The test suite expects insecure connections and that the SQL
port is on 26257.
@DarrylWong DarrylWong changed the title roachtest: run sequelize on insecure mode roachtest: run sequelize on insecure mode and default sql port May 13, 2024
@DarrylWong
Copy link
Contributor Author

The suite does attempt to read in env.COCKROACH_PORT, but I wasn't able to get it to work. Seemed to still hardcode 26257 in some places. Since this test still seems WIP having it run at all seems like a better option for now over messing with the test suite adapter but let me know.

@DarrylWong DarrylWong marked this pull request as ready for review May 13, 2024 18:08
Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ran this a few times on my gceworker) lgtm -- ty!

@DarrylWong
Copy link
Contributor Author

TFTR!

bors r=annrpom

@DarrylWong DarrylWong added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels May 13, 2024
@craig craig bot merged commit 264a264 into cockroachdb:master May 13, 2024
22 checks passed
Copy link

blathers-crl bot commented May 13, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 15a2dbb to blathers/backport-release-23.1-124053: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants