kvcoord: add proxy tracing test #124043
kvcoord: add proxy tracing test #124043
Conversation
Add `TestProxyTracing`, which asserts that when a partition partition is enabled a (1) request is proxied via another node to the leaseholder and (2) the trace captures the relevant event. Resolves: cockroachdb#124036 Release note: None
|
This change is |
There was a problem hiding this comment.
Thanks for adding! I'll try and track down the failing SELECT later today.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
pkg/kv/kvclient/kvcoord/dist_sender_server_test.go line 4890 at r1 (raw file):
} // Wait until the leaseholder for the test table ranges are on n3.
nit: look at relocateLeases in failover.go for a faster way to do this using ALTER RANGE RELOCATE LEASE. This will remove the need for the lease queue at all and likely make the test complete faster.
There was a problem hiding this comment.
TYFTR!
Reviewable status:
pkg/kv/kvclient/kvcoord/dist_sender_server_test.go line 4890 at r1 (raw file):
Previously, andrewbaptist (Andrew Baptist) wrote…
nit: look at
relocateLeasesin failover.go for a faster way to do this usingALTER RANGE RELOCATE LEASE. This will remove the need for the lease queue at all and likely make the test complete faster.
checkLeaseCount is force processing leases on n1. It seems almost equivalent here. The test passes fairly quickly so I'll leave it be for now.
|
TYFTR bors r=andrewbaptist |
|
Build succeeded: |
Add
TestProxyTracing, which asserts that when a partition partition is enabled a (1) request is proxied via another node to the leaseholder and (2) the trace captures the relevant event.Resolves: #124036
Release note: None