Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvcoord: add dist sender proxy tracing test #124036

Closed
kvoli opened this issue May 13, 2024 · 1 comment · Fixed by #124043
Closed

kvcoord: add dist sender proxy tracing test #124036

kvoli opened this issue May 13, 2024 · 1 comment · Fixed by #124043
Assignees
@kvoli
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-kv KV Team
Projects
KV

Comments

@kvoli
Copy link
Collaborator

kvoli commented May 13, 2024 •
edited by cockroach-jira-scripts

Add a unit test which asserts that a proxied request adds the relevant log lines to a collected trace (see #123440).

e.g.

https://github.com/kvoli/cockroach/blob/ae98bbafc28df8d60b28d82c82e89707862e38c7/pkg/server/node.go#L1541-L1541

https://github.com/kvoli/cockroach/blob/ae98bbafc28df8d60b28d82c82e89707862e38c7/pkg/server/node.go#L1544-L1544

Note its possible that the proxied request may end up evaluating locally as a follower read without proxying, which is considered valid.

Jira issue: CRDB-38672
@kvoli kvoli added the T-kv KV Team label May 13, 2024
@blathers-crl blathers-crl bot added this to Incoming in KV May 13, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented May 13, 2024

Hi @kvoli, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@kvoli kvoli added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-kv KV Team and removed T-kv KV Team labels May 13, 2024
@kvoli kvoli self-assigned this May 13, 2024
@exalate-issue-sync exalate-issue-sync bot assigned kvoli and unassigned kvoli May 13, 2024
kvoli added a commit to kvoli/cockroach that referenced this issue May 13, 2024
@kvoli
kvcoord: add proxy tracing test
a38dba3 
Add `TestProxyTracing`, which asserts that when a partition partition is
enabled a (1) request is proxied via another node to the leaseholder and
(2) the trace captures the relevant event.

Resolves: cockroachdb#124036
Release note: None
@kvoli kvoli mentioned this issue May 13, 2024
Merged
craig bot pushed a commit that referenced this issue May 14, 2024
@kvoli
Merge #124043
bb4479c 
124043: kvcoord: add proxy tracing test r=andrewbaptist a=kvoli

Add `TestProxyTracing`, which asserts that when a partition partition is enabled a (1) request is proxied via another node to the leaseholder and (2) the trace captures the relevant event.

Resolves: #124036
Release note: None

Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
@craig craig bot closed this as completed in 724d6bb May 14, 2024
blathers-crl bot pushed a commit that referenced this issue May 14, 2024
@kvoli
kvcoord: add proxy tracing test
3e1634e 
Add `TestProxyTracing`, which asserts that when a partition partition is
enabled a (1) request is proxied via another node to the leaseholder and
(2) the trace captures the relevant event.

Resolves: #124036
Release note: None
@blathers-crl blathers-crl bot mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-kv KV Team
Projects
KV
Incoming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvcoord: add proxy tracing test kvoli/cockroach
1 participant
@kvoli