test rhel4edge: changes inside new images, used symlink for home dir. #20480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscotka
changed the title
Terminal plugin will dereference symlink to /var/home/admin, although user is created with home /home/admin and /home is symlink to var/home Issue: cockpit-project#20479
jscotka
changed the title
1 task
martinpitt
reviewed
May 22, 2024
Comment on lines
+86
to
+87
| if m.image.startswith("rhel4edge") and "admin]" in prompt: | ||
| self.assertIn("admin]$", prompt) |
There was a problem hiding this comment.
This is too much of a static hack IMHO -- the next rhel4edge refresh may change this again, and it breaks on the current image. IMHO this is a bug in creating the "admin" user, I'll follow up to cockpit-project/bots#6362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue:
#20479
Directly connected with PR inside bots: cockpit-project/bots#6362