workflows: Run trigger-anaconda in our tasks container #20477
Conversation
It has everything and Rawhide is moving stuff around a lot recently.
|
A almost-successful run here: https://github.com/mvollmer/cockpit/actions/runs/9115006365/job/25060286605?pr=50 This was in a PR against my own fork, and it failed because packit doesn't run for my fork. |
| @@ -19,16 +19,18 @@ jobs: | |||
| permissions: | |||
| contents: read | |||
| statuses: write | |||
| container: registry.fedoraproject.org/fedora:rawhide | |||
| container: | |||
| image: ghcr.io/cockpit-project/tasks | |||
There was a problem hiding this comment.
Why not a more usual stable fedora image like 40?
There was a problem hiding this comment.
Good question! My impression was that we are moving towards running as much as possible inside our task container, so that we need to worry about as few containers as possible. And this workflow calls bots/tests-trigger, and our task container is meant to execute bots code like this, no?
So, my impression is task-container == some stable thing plus dependencies required by our bots. Is that not so?
There was a problem hiding this comment.
If we want to run this in the tasks container, then I feel like we should make sure we already have the dependencies that this thing needs present in the tasks container.
So like:
- use tasks container; or
- standard image +
dnf installsome stuff
pick one.
Downloading the much larger image and having to do dnf anyway seems like a real waste of time...
It has everything and Rawhide is moving stuff around a lot recently.