storage: Don't warn about missing bitmap when MDRAID has a journal #20404
+43
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-no-bitmap-with-journal
branch
from
d6c0dc0
to
096d664
Compare
|
UDisks2 will have a ConsistencyPolicy in the next release. We can already start to use it here. |
A mdraid can have different consistency policies, and "bitmap" is only one of them. We should only tell people to add a bitmap when the policy is "resync". UDisks2 will have a ConsistencyPolicy property soonish, and we approximate its value until then. Fixes cockpit-project#20381
mvollmer
force-pushed
the
storage-no-bitmap-with-journal
branch
from
096d664
to
670d22a
Compare
cockpituous
reviewed
May 3, 2024
| @@ -174,9 +174,19 @@ function add_disk(mdraid) { | |||
| } | |||
|
|
|||
| function missing_bitmap(mdraid) { | |||
| let policy; | |||
| if (mdraid.ConsistencyPolicy) | |||
| policy = mdraid.ConsistencyPolicy; | |||
There was a problem hiding this comment.
This added line is not executed by any test.
jelly
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mdraid can have different consistency policies, and "bitmap" is only one of them. We should only tell people to add a bitmap when the policy is "resync".
UDisks2 and Cockpit don't understand consistency policy at all, so we do the bare minimum here to detect a journal.
Fixes #20381