[rhel-8] test: Drop obsolete compat test cases for RHEL/CentOS 7, adjust for TEST_OS_DEFAULT moving to F40 #20393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On June 30, CentOS 7 is EOL and RHEL 7 reaches end-of-maintenance [1]. We haven't changed anything on our rhel-7.9 branch in years, we can put these images to rest. This also means that we can stop supporting the old "implicit superuser" backwards compatibility, as all supported OSes now use the explicit dialog. Drop the various TestSuperuserOld* tests. Also drop TestCentos7 -- we already have a TestRHEL8 for testing connectivity to the C bridge. Drop the `wait_popdown()` testlib API. It's not being used anywhere any more, so vulture complains. External projects don't use it either, and it's too trivial to keep around. [1] https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance Cherry-picked from main commit 78ca854
2 tasks
|
The kdump regression is currently being investigated in cockpit-project/bots#6262 and #20373. This seems to be some change in our CI. |
1 task
|
But this on the other hand is new -- it happens in cockpit-project/bots#6311 but how did it break? it still passed in the previous refresh in cockpit-project/bots#6255. Well, shrug, I'll adjust the tests. |
|
Ah, I know! This is due to the change of TEST_OS_DEFAULT to F40. |
martinpitt
changed the title
Fallout from moving TEST_OS_DEFAULT to Fedora 40. RHEL 8 does not yet know about this SELinux flag, so ignore it in the comparison.
|
CI is still unhappy :( I fear this requires some debugging on my side. |
jelly
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On June 30, CentOS 7 is EOL and RHEL 7 reaches end-of-maintenance [1]. We haven't changed anything on our rhel-7.9 branch in years, we can put these images to rest.
This also means that we can stop supporting the old "implicit superuser" backwards compatibility, as all supported OSes now use the explicit dialog. Drop the various TestSuperuserOld* tests.
Also drop TestCentos7 -- we already have a TestRHEL8 for testing connectivity to the C bridge.
Drop the
wait_popdown()testlib API. It's not being used anywhere any more, so vulture complains. External projects don't use it either, and it's too trivial to keep around.[1] https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance
Cherry-picked from main commit 78ca854
Blocks cockpit-project/bots#6311