build: Drop --enable-old-bridge configure option #20213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't supported on the main branch any more since we dropped supprot for RHEL 8. This was already cleaned up in the spec file and tests. `HACK_SPEC_FOR_PYTHON` is also not a thing any more. Also clean up the four ws tests which we haven't run any more since then. Much of src/bridge can also go now, but we'll leave that for cockpit-project#20000. As automake requires a defined conditional for `if`, define an always-false `WITH_OLD_BRIDGE` for now.
martinpitt
commented
Mar 22, 2024
Comment on lines
+42
to
43
| # TODO: remove all of the below | ||
| if WITH_OLD_BRIDGE |
There was a problem hiding this comment.
FTR: I tried with if 0 or if REMOVE_ME etc., but none of that works. There just isn't a multi-line "disable this section" in automake that I know of 馃槩 I am happy to just remove the block here, but then we should also remove all the files (as this Makefile block is the reference list of which files can go), and then I step too much on Lis'es toes.
|
@allisonkarlitskaya: This doesn't block me after all, so I'll leave it up to you what you want to do with this -- land, reject, or expand into #20000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't supported on the main branch any more since we dropped supprot for RHEL 8. This was already cleaned up in the spec file and tests.
HACK_SPEC_FOR_PYTHONis also not a thing any more.Also clean up the four ws tests which we haven't run any more since then.
Much of src/bridge can also go now, but we'll leave that for #20000. As automake requires a defined conditional for
if, define an always-falseWITH_OLD_BRIDGEfor now.NB: This is not the big cleanup from #20000 yet. I added that conditional hack specifically to avoid that 馃榿 A lot of that can happen now, but @allisonkarlitskaya reserved that fun for her. I mostly just want to get rid of the OLD_BRIDGE configure stuff as I keep running into it while working on #19441