fixes i can right click on a context menu #20185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
requested changes
Mar 18, 2024
There was a problem hiding this comment.
This fix has some issues:
-
Right clicking on the context menu now moves the context menu
Screencast from 2024-03-18 11-17-00.webm -
This causes a JavaScript error, when I right click in the terminal, close click outside of the page (on the top bar)
Then click in the terminal again
Uncaught TypeError: Cannot read properties of null (reading 'contains')
at HTMLDocument.u (terminal.js:16:214144)
|
Sorry, after checking the issue, I found that it was in navigator and not an actual issue in Cockpit itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20139